feat: add Redirect and deprecate new_redirect #451
Merged
+79
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Bencher Report| Branch | redirect |
| Testbed | github-ubuntu-latest |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result microseconds (µs) (Result Δ%) | Upper Boundary microseconds (µs) (Limit %) |
|---|---|---|---|
| empty_router/empty_router | 📈 view plot 🚷 view threshold | 6,217.70 µs(+2.58%)Baseline: 6,061.14 µs | 6,856.71 µs (90.68%) |
| json_api/json_api | 📈 view plot 🚷 view threshold | 1,017.30 µs(-0.58%)Baseline: 1,023.19 µs | 1,139.23 µs (89.30%) |
| nested_routers/nested_routers | 📈 view plot 🚷 view threshold | 939.68 µs(-0.55%)Baseline: 944.91 µs | 1,047.09 µs (89.74%) |
| single_root_route/single_root_route | 📈 view plot 🚷 view threshold | 906.43 µs(+0.19%)Baseline: 904.73 µs | 1,001.74 µs (90.49%) |
| single_root_route_burst/single_root_route_burst | 📈 view plot 🚷 view threshold | 18,018.00 µs(+2.35%)Baseline: 17,604.72 µs | 20,818.67 µs (86.55%) |
Codecov Report✅ All modified and coverable lines are covered by tests.
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes 🚀 New features to boost your workflow:
|
seqre
force-pushed
the
redirect
branch
2 times, most recently
from
3d17c14 to
a41efa8
Compare
m4tx
requested changes
Jan 21, 2026
m4tx
reviewed
Jan 21, 2026
m4tx
approved these changes
Jan 21, 2026
Member
m4tx
left a comment
m4tx
left a comment
There was a problem hiding this comment.
Please make sure my concerns are addressed, and the test is added. Feel free to merge this afterwards!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.