Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(pre-commit.ci): pre-commit autoupdate #6

Merged
merged 2 commits into from
Jan 8, 2025

Conversation

pre-commit-ci[bot]
Copy link
Contributor

@pre-commit-ci pre-commit-ci bot commented Aug 5, 2024

Copy link

codecov bot commented Aug 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Flag Coverage Δ
rust 84.03% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Member

@seqre seqre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The mirrors-prettier is archived and should no longer be used. Citing the authors:

prettier made some changes that breaks plugins entirely

We should replace it with something maintained.

@m4tx
Copy link
Member

m4tx commented Aug 15, 2024

https://github.com/google/yamlfmt is a possible alternative, as we use prettier only to format yaml and json files anyways.

updates:
- [github.com/pre-commit/pre-commit-hooks: v4.6.0 → v5.0.0](pre-commit/pre-commit-hooks@v4.6.0...v5.0.0)
- [github.com/pre-commit/mirrors-prettier: v3.1.0 → v4.0.0-alpha.8](pre-commit/mirrors-prettier@v3.1.0...v4.0.0-alpha.8)
@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch from bdbe816 to 45c6e86 Compare November 4, 2024 23:09
@m4tx
Copy link
Member

m4tx commented Jan 8, 2025

I'll merge these changes for now and I'll spin up a separate PR for replacing prettier with google/yamlfmt.

@m4tx m4tx merged commit 320969c into master Jan 8, 2025
26 checks passed
@m4tx m4tx deleted the pre-commit-ci-update-config branch January 8, 2025 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants