-
-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
prompt doesn't seem to do the right thing for nested blockquotes #846
Labels
bug
Something isn't working
Comments
👋 Hi @brevzin, This issue is being automatically closed because it does not follow the issue template. Please DO NOT open another similar issue, try to edit the current issue according to the template, then it will be reopened automatically. |
cotes2020
changed the title
prompt-meow doesn't seem to do the right thing for nested blockquotes
prompt doesn't seem to do the right thing for nested blockquotes
Jan 29, 2023
Gaur4vGaur
added a commit
to Gaur4vGaur/Gaur4vGaur.github.io
that referenced
this issue
Feb 3, 2023
author Gaurav Gaur <Gaur4vGaur@users.noreply.github.com> 1675074395 +0000 committer Gaurav Gaur <Gaur4vGaur@users.noreply.github.com> 1675445316 +0000 parent 6c35647 author Gaurav Gaur <Gaur4vGaur@users.noreply.github.com> 1675074395 +0000 committer Gaurav Gaur <Gaur4vGaur@users.noreply.github.com> 1675445269 +0000 parent 6c35647 author Gaurav Gaur <Gaur4vGaur@users.noreply.github.com> 1675074395 +0000 committer Gaurav Gaur <Gaur4vGaur@users.noreply.github.com> 1675445201 +0000 parent 6c35647 author Gaurav Gaur <Gaur4vGaur@users.noreply.github.com> 1675074395 +0000 committer Gaurav Gaur <Gaur4vGaur@users.noreply.github.com> 1675445170 +0000 parent 6c35647 author Gaurav Gaur <Gaur4vGaur@users.noreply.github.com> 1675074395 +0000 committer Gaurav Gaur <Gaur4vGaur@users.noreply.github.com> 1675445041 +0000 progress with pipes and filters pattern feat: add shimmer background when image loads feat: set preview image ratio to 1.91 : 1 fix: `og:image` will be incorrect if the image uses a cross-domain URL feat: support dark and light mode images (cotes2020#481) refactor: unify the border radius of blocks scope: code blocks, prompts, images, and videos feat: add `rel="me"` to Mastodon sidebar contact links for verification (cotes2020#807) This will enable verification with Mastodon by including the `rel="me"` attribute. https://docs.joinmastodon.org/user/profile/#verification Co-authored-by: Cotes Chung <11371340+cotes2020@users.noreply.github.com> chore: hide blur edge of LQIP images chore(tools): checkout latest tag on initialization chore(editorconfig): keep trailing spaces in Markdown (cotes2020#830) feat(i18n): add Czech language (cotes2020#833) fix: correct encoding of spaces in share URLs (cotes2020#835) Resolves cotes2020#835 fix: post's image would cover the PWA update alert feat(i18n): add Finnish translations (cotes2020#843) chore(bundler): deprecate `:install_if` option in Gemfile feat(i18n): add Italian translation (cotes2020#850) fix: copy command line incomplete(`.gp` part) feat(i18n): add Arabic translation (cotes2020#857) chore(deps): liquid(v4.0.4) is compatible with ruby 3.2 (cotes2020#854) See: jekyll/jekyll#9231 chore: ignore gem lock file in user-end refactor: optimize tab cursor position calculation fix: prompt with nested blockquotes renders incorrectly (cotes2020#846) Resolves cotes2020#846 chore(release): 5.5.0 fix: the icon position of the prompts in the list is incorrect chore(release): 5.5.1
songkg7
pushed a commit
to songkg7/songkg7.github.io-legacy
that referenced
this issue
Feb 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Checklist
master
branch.Describe the bug
This markdown:
renders correctly:
But if you change the class to
prompt-meow
(e.g. to use info, warning, etc.), then an extra<div>
gets inserted:Which causes the last paragraph to be printed outside of the outer blockquote (and thus outside of the prompt). I'm not sure why that is, exactly, but it's something about the
prompt-*
logic here.To Reproduce
Add this into any post:
Expected behavior
I expect to see nested quotes, all within an info block.
Screenshots
Instead, this is how it's rendered:
Environment
ruby -v
gem -v
bundle -v
bundle exec jekyll -v
bundle info jekyll-theme-chirpy
Desktop
Smartphone
Additional context
The text was updated successfully, but these errors were encountered: