-
-
Notifications
You must be signed in to change notification settings - Fork 6.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
style(scss): Fix various accessibility issues #1104
style(scss): Fix various accessibility issues #1104
Conversation
@TheEvilSkeleton thanks for the effort. this helps me with my own blog css styles. |
Good point, thanks! |
ddafd13
to
e1601d0
Compare
@sublimeclemency it's ready for review |
can we make all edits to this file "\assets\css\style.scss" ? or it's for something else? ---
---
@import '{{ site.theme }}';
/* append your custom style below */ instead of editing the core theme ".scss" files! |
The goal is to fix various accessibility issues within the core theme. |
Description
This improves the contrast of certain text elements to make it easier to read.
Type of change
Additional context
Fixes #1095
How has this been tested
bash ./tools/test
(at the root of the project) locally and passedDo note that I haven't generated the website as it doesn't work for me on neither this branch and the
master
branch. I used Firefox DevTools.Using https://orowith2os.gitlab.io/posts/Flatpak-an-insecurity-nightmare as an example: