Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style(scss): Fix various accessibility issues #1104

Closed

Conversation

TheEvilSkeleton
Copy link

@TheEvilSkeleton TheEvilSkeleton commented Jun 23, 2023

Description

This improves the contrast of certain text elements to make it easier to read.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (refactoring and improving code)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Additional context

Fixes #1095

How has this been tested

  • I have run bash ./tools/test (at the root of the project) locally and passed
  • I have tested this feature in the browser

Do note that I haven't generated the website as it doesn't work for me on neither this branch and the master branch. I used Firefox DevTools.

Using https://orowith2os.gitlab.io/posts/Flatpak-an-insecurity-nightmare as an example:

Before After
image image
image image

@sublimeclemency
Copy link

sublimeclemency commented Jun 30, 2023

@TheEvilSkeleton thanks for the effort. this helps me with my own blog css styles.
In the first commit of this draft, you changed _sass/addon/module.scss %sidebar-links to make the color darkgray. this only has a good effect in dark mode.
for better accessibility, change to var(--text-color)

@TheEvilSkeleton
Copy link
Author

TheEvilSkeleton commented Jul 3, 2023

Good point, thanks!

@TheEvilSkeleton
Copy link
Author

TheEvilSkeleton commented Jul 3, 2023

I bumped the contrast of --text-color so that --text-muted-color could be bumped as well. To be honest, I think it looks better that way.

Before After
image image
image image

@TheEvilSkeleton
Copy link
Author

TheEvilSkeleton commented Jul 3, 2023

Before After
image image
image image
image image

@TheEvilSkeleton TheEvilSkeleton marked this pull request as ready for review July 3, 2023 03:24
@TheEvilSkeleton
Copy link
Author

@sublimeclemency it's ready for review

@Mohamed3nan
Copy link
Contributor

Mohamed3nan commented Jul 5, 2023

can we make all edits to this file "\assets\css\style.scss" ? or it's for something else?

---
---

@import '{{ site.theme }}';

/* append your custom style below */

instead of editing the core theme ".scss" files!

@TheEvilSkeleton
Copy link
Author

The goal is to fix various accessibility issues within the core theme.

@TheEvilSkeleton TheEvilSkeleton changed the title style(scss): Fix a few accessibility issues style(scss): Fix various accessibility issues Jul 9, 2023
@cotes2020 cotes2020 closed this in 7283624 Aug 1, 2023
@TheEvilSkeleton TheEvilSkeleton deleted the fix-contrast-issues branch August 1, 2023 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bad contrast
3 participants