The CJK characters of the "Search Cancel" button will wrap #1105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cotes2020
requested changes
Jun 26, 2023
cotes2020
requested changes
Jun 26, 2023
cotes2020
changed the title
cotes2020
requested changes
Jun 26, 2023
_sass/addon/commons.scss
Outdated
| @@ -959,6 +959,7 @@ $btn-mb: 0.5rem; | |||
| color: var(--link-color); | |||
| margin-left: 1rem; | |||
There was a problem hiding this comment.
Alright, please ignore the modification request above. Keep your changes, and add a margin improvement:
Suggested change
| margin-left: 1rem; | |
| margin-left: 0.75rem; |
cotes2020
approved these changes
Jun 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
H5 search cancel text arranges vertically when lang switched to zh-CN. I think it is a bug.
Type of change
Additional context
How has this been tested
follow the contribution doc，fork the project and clone it locally
install deps
change
_config.yml:lang: entolang: zh-CNrun
npm run build && bundle exec jekyll serveview in chrome devtool with mobile mode, click search icon, you will see "取消" arranging vertically at right side
with this commit, reproduce above steps and get the correct render result.
I have run
bash ./tools/test(at the root of the project) locally and passedI have tested this feature in the browser