Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update commons.scss icon for prompt-info #1130

Closed
wants to merge 1 commit into from

Conversation

khoguan
Copy link

@khoguan khoguan commented Jul 6, 2023

Description

Both the icons for .prompt-info and .promt-warning are '\f06a'. But the icon for .prompt-info should be '\f05a' (circle-info from fontawesome), not '\f06a' (circle-exclamation).

Type of change

  • Bug fix (non-breaking change which fixes an issue)

The icon for .prompt-info should be '\f05a' (circle-info from fontawesome), not 'f06a' (circle-exclamation).
Copy link
Owner

@cotes2020 cotes2020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The icon was chosen based on how it looks, not the name.

@cotes2020 cotes2020 closed this Jul 31, 2023
@cotes2020 cotes2020 mentioned this pull request Oct 28, 2023
5 tasks
cotes2020 added a commit that referenced this pull request Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants