Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use explicit url for goatcounter #1578

Merged
merged 1 commit into from
Feb 29, 2024

Conversation

kungfux
Copy link
Collaborator

@kungfux kungfux commented Feb 29, 2024

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Description

Explicit GoatCounter URL was changed to a protocol-relative URL while doing refactoring #1543 which causes issues.

Run bundle exec htmlproofer _site \
Running 3 checks (Scripts, Links, Images) in ["_site"] on *.html files...

Checking [18](https://github.com/kungfux/kungfux.github.io/actions/runs/8101471704/job/22141725592#step:6:19)0 internal links
Checking internal link hashes in [19](https://github.com/kungfux/kungfux.github.io/actions/runs/8101471704/job/22141725592#step:6:20) files
Ran on 88 files!


For the Scripts check, the following failures were found:

* At _site/404.html:1:

  script link //gc.zgo.at/count.js is a protocol-relative URL, use explicit https:// instead

* At _site/about/index.html:51:

  script link //gc.zgo.at/count.js is a protocol-relative URL, use explicit https:// instead
...

Additional context

This is not released yet and introduced by #1543

@kungfux kungfux self-assigned this Feb 29, 2024
Copy link
Owner

@cotes2020 cotes2020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I was referring to the GoatCounter official docs at #1543, thanks for the fix.

@cotes2020 cotes2020 changed the title fix: use explicit url for goatcounter refactor: use explicit url for goatcounter Feb 29, 2024
@cotes2020
Copy link
Owner

Please consider using a refactor type for the commit message, so that we don't leave this extra record in changelog.

@kungfux kungfux force-pushed the fix/goatcounter-use-explicit-url branch from 788deaf to f906fee Compare February 29, 2024 19:56
@kungfux kungfux merged commit e24a0c7 into cotes2020:master Feb 29, 2024
5 checks passed
@kungfux kungfux deleted the fix/goatcounter-use-explicit-url branch February 29, 2024 20:01
Copy link

🎉 This PR is included in version 7.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot added the released Included or resolved in the release label May 11, 2024
kimbob13 pushed a commit to kimbob13/kimbob13.github.io that referenced this pull request May 25, 2024
gudtldn pushed a commit to gudtldn/gudtldn.github.io that referenced this pull request Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Included or resolved in the release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants