fix: close popup gracefully with Esc key #1990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cotes2020
requested changes
Oct 13, 2024
kungfux
force-pushed
the
bugfix/handle-popup-close-by-esc
branch
from
44e5253
to
7a7f52a
Compare
cotes2020
approved these changes
Oct 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
Problem: Closing a popup by pressing
Escis not handled correctly.Scenario:
ContentsEsckeyExpected: Popup is closed with animation.
Actual/Problem: Popup is closed without animation.
ContentsagainExpected: Popup can be opened again.
Actual/Problem: Popup is being closed on open (for the first time after closing). See recording attached.
Recording
Ref #1964