Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use jsonify to generate valid JSON #521

Merged
merged 1 commit into from
Mar 3, 2022
Merged

Use jsonify to generate valid JSON #521

merged 1 commit into from
Mar 3, 2022

Conversation

ZakKemble
Copy link
Contributor

Description

Invalid JSON is generated when a post contains tab characters since the remove_chars filter plugin is missing ( https://github.com/christian-fei/Simple-Jekyll-Search/tree/master/example/_plugins ). Use jsonify instead.

Relates to #475

Even if the text editor has been configured to use spaces instead of tabs, Rouge syntax highlighter will generate tabs in its tables.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How has this been tested

  • I have run bash ./tools/deploy.sh --dry-run (at the root of the project) locally and passed
  • I have tested this feature in the browser

Test Configuration

  • Browser type & version: Firefox 97.0.1
  • Operating system: Windows 10
  • Ruby version: 2.7.4p191
  • Bundler version: 2.3.8
  • Jekyll version: 4.2.1

Checklist

  • I have performed a self-review of my code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Copy link
Owner

@cotes2020 cotes2020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

many thanks!

@cotes2020 cotes2020 merged commit dd9d5a7 into cotes2020:master Mar 3, 2022
dkbnz pushed a commit to dkbnz/jekyll-theme-chirpy that referenced this pull request Jul 12, 2022
shihtiy-tw pushed a commit to shihtiy-tw/shihtiy-tw.github.io that referenced this pull request Nov 26, 2022
sanjidnet pushed a commit to sanjidnet/sanjidnet.github.io that referenced this pull request Jan 9, 2023
Ap3x pushed a commit to Ap3x/ap3x.github.com that referenced this pull request Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants