Defer feeding XML data until we likely trigger an event #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recent changes to expat, the XML parser behind the Python XMLPullParser, utilize a backoff when feeding the parser in small chunks which don't (yet) constitute something interesting. Unfortunately, this could result in the parser sitting on a completed payload waiting for more data before it attempts parsing. The safest mitigation I can find is to just wait until we get a '>' before feeding the parser, which should hopefully mean that we'll never trigger the backoff.
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #29 +/- ##
==========================================
- Coverage 87.00% 86.97% -0.03%
==========================================
Files 7 7
Lines 800 806 +6
==========================================
+ Hits 696 701 +5
- Misses 104 105 +1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent changes to expat, the XML parser behind the Python XMLPullParser, utilize a backoff when feeding the parser in small chunks which don't (yet) constitute something interesting. Unfortunately, this could result in the parser sitting on a completed payload waiting for more data before it attempts parsing.
The safest mitigation I can find is to just wait until we get a '>' before feeding the parser, which should hopefully mean that we'll never trigger the backoff.
See python/cpython#115133 for related comments.