Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add aioraven package to rosdep (key should end in -pip) #12

Closed
wants to merge 1 commit into from

Conversation

cottsay
Copy link
Owner

@cottsay cottsay commented Jul 23, 2024

No description provided.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an automated review.

For changes related to rosdep:

  • ❌ There are problems with the names of new rosdep keys:
    • Keys which contain only pip rules should end in '-pip'

Comment on lines +4854 to +4855
python3-aioraven:
'*':

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This key should end in '-pip'

Copy link

github-actions bot commented Aug 7, 2024

This PR hasn't been activity in 14 days. If you are still are interested in getting it merged please provide an update. Otherwise it will likely be closed by a rosdistro maintainer following our contributing policy. It's been labeled "stale" for visibility to the maintainers. If this label isn't appropriate, you can ask a maintainer to remove the label and add the 'persistent' label.

@github-actions github-actions bot added the stale label Aug 7, 2024
@cottsay cottsay closed this Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant