Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add aioraven package to rosdep (missing -pip in key) #9

Closed
wants to merge 1 commit into from

Conversation

cottsay
Copy link
Owner

@cottsay cottsay commented Jul 23, 2024

No description provided.

@cottsay cottsay closed this Jul 23, 2024
@cottsay cottsay reopened this Jul 23, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an automated review.

For changes related to rosdep:

  • ❌ There are problems with the names of new rosdep keys:
    • Keys which contain only pip rules should end in '-pip'

Comment on lines +4854 to +4855
python3-aioraven:
'*':

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This key should end in '-pip'

@cottsay cottsay force-pushed the aioraven-no-pip-name branch from 833652a to 66154ec Compare July 23, 2024 15:03
@cottsay cottsay closed this Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant