Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds support for custom token TTL via the authenticate endpoint and HTML form #1873

Merged
merged 1 commit into from
Jun 14, 2016

Conversation

ajres
Copy link

@ajres ajres commented Jun 14, 2016

fixes #1847


This change is Reviewable

@tleyden
Copy link
Contributor

tleyden commented Jun 14, 2016

The unit tests failed with this error:

https://gist.github.com/tleyden/4d6ae597c0d0cbb5f5a6f156a59ff4a7

Going to re-run

@tleyden
Copy link
Contributor

tleyden commented Jun 14, 2016

Re-running, failed with the same error. @ajres can you run the full test suite locally and see if it's passing for you?

You can see the test params here: https://github.com/couchbase/sync_gateway/blob/master/.drone.yml

./test.sh -race -cpu 4

@tleyden
Copy link
Contributor

tleyden commented Jun 14, 2016

It doesn't look like the unit test failure could have anything to do with this change though .. I wonder if we should just merge it? @adamcfraser any thoughts?

@adamcfraser
Copy link
Collaborator

I haven't seen that failure running locally. It looks like the usual 'bucket is closed before db is stopped' error. In any case it looks unrelated to this change - I think it's ok to merge.

@tleyden tleyden merged commit 7132c62 into master Jun 14, 2016
@tleyden tleyden deleted the feature/issue_1847 branch June 14, 2016 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Have a way to configure tokens for expiry in POST request
3 participants