enable ineffassign #6102
Merged
enable ineffassign #6102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
torcolvin
force-pushed
the
torcolvin/ineffassign
branch
3 times, most recently
from
3f9a97c to
32c2fee
Compare
torcolvin
force-pushed
the
torcolvin/ineffassign
branch
from
32c2fee to
a908616
Compare
adamcfraser
reviewed
Mar 2, 2023
| @@ -325,12 +325,12 @@ func (op *OIDCProvider) initOIDCClient(ctx context.Context) error { | |||
| return err | |||
| } | |||
|
|
|||
| metadata, verifier, err := op.DiscoverConfig(ctx) | |||
| metadata, _, err := op.DiscoverConfig(ctx) | |||
There was a problem hiding this comment.
It doesn't look like this leaves any consumers for the verifier returned by DiscoverConfig. I'm not convinced this was an intentional change. I realize this PR doesn't change that, but I feel this might merit a tracking ticket to evaluate whether we should be using the verifier returned by DiscoverConfig in the case where we're using standard discovery.
There was a problem hiding this comment.
adamcfraser
approved these changes
Apr 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add ineffassign to required linters. Nearly all changes are test changes except:
The other non test changes are just removing unused variables.
Pre-review checklist
fmt.Print,log.Print, ...)base.UD(docID),base.MD(dbName))docs/apiIntegration Tests
GSI=true,xattrs=truehttps://jenkins.sgwdev.com/job/SyncGateway-Integration/1567/