Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CBG-2412: Leaking rest/replicator_test.go goroutines #6181

Merged
merged 4 commits into from
Apr 12, 2023
Merged

CBG-2412: Leaking rest/replicator_test.go goroutines #6181

merged 4 commits into from
Apr 12, 2023

Conversation

gregns1
Copy link
Contributor

@gregns1 gregns1 commented Apr 12, 2023

CBG-2412

A small PR that fixes leaking goroutines in blip sender/receiver and a http server leak. Attached is the pprof output for the replicator test package now.

  • http server leak came friom the collectiosn test, missing a close afrter the creation of the object
  • There was a test in the main replicator_test file that wasn't stopping a replication properly. I've changed the test to use sgr peers helper function to make use of the teardown function. Also made use of the create replication helper function as it just makes the test more readable.

Screenshot 2023-04-12 at 15 30 24

Pre-review checklist

  • Removed debug logging (fmt.Print, log.Print, ...)
  • Logging sensitive data? Make sure it's tagged (e.g. base.UD(docID), base.MD(dbName))
  • Updated relevant information in the API specifications (such as endpoint descriptions, schemas, ...) in docs/api

Integration Tests

gregns1 added 2 commits April 12, 2023 13:57
…t properly stopping befroe the end of the test and another for a http svr not closed after creation
@gregns1 gregns1 self-assigned this Apr 12, 2023
@bbrks bbrks merged commit b6a6059 into master Apr 12, 2023
@bbrks bbrks deleted the CBG-2412 branch April 12, 2023 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants