Always close bootstrap connections from ServerContext.Close() #6215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xt closes - even if we weren't polling for config updates
adamcfraser
approved these changes
Apr 26, 2023
adamcfraser
requested changes
Apr 26, 2023
| err = base.TerminateAndWaitForClose(sc.BootstrapContext.terminator, sc.BootstrapContext.doneChan, serverContextStopMaxWait) | ||
| if err != nil { | ||
| base.InfofCtx(ctx, base.KeyAll, "Couldn't stop background config update worker: %v", err) | ||
| } | ||
|
|
||
| // close cached bootstrap bucket connections |
There was a problem hiding this comment.
Should this be inside sc.lock.Lock(), to avoid races calling Connection.Close()?
adamcfraser
approved these changes
Apr 26, 2023
adamcfraser
deleted the
always_close_bootstrap_bucket_connections_on_server_close
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Always close cached bootstrap bucket connections when the ServerContext closes - even if we weren't polling for config updates (like when started from a RestTester)
This reduces memory usage, lingering goroutines and connections for tests that start RestTester in persistent config mode (which intentionally does not poll for config updates).
Pre-review checklist
fmt.Print,log.Print, ...)base.UD(docID),base.MD(dbName))docs/apiIntegration Tests
GSI=true,xattrs=truehttps://jenkins.sgwdev.com/job/SyncGateway-Integration/1737/