Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow rbac tests to run #6225

Merged
merged 2 commits into from
May 4, 2023
Merged

allow rbac tests to run #6225

merged 2 commits into from
May 4, 2023

Conversation

torcolvin
Copy link
Collaborator

I'm not actually sure what feature is only supported in 7.1 in this test - I think it's user creation, but if it's not, let me know how to change this test.

There were a few changes to make to this test with database and keyspace which are expected.

Unexpected was that /_stats and /_expvar/ are granted to syncGatewayConfigurator

Pre-review checklist

  • Removed debug logging (fmt.Print, log.Print, ...)
  • Logging sensitive data? Make sure it's tagged (e.g. base.UD(docID), base.MD(dbName))
  • Updated relevant information in the API specifications (such as endpoint descriptions, schemas, ...) in docs/api

Integration Tests

Copy link
Collaborator

@adamcfraser adamcfraser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The majority of the RBAC permissions being used in that test (sync_gateway_dev_ops, etc - everything except mobile_sync_gateway) didn't exist until server 7.1. So instead of supportsSettingRBAC, the cluster capability is more like 'includes mobile permissions'.

@adamcfraser adamcfraser assigned torcolvin and unassigned adamcfraser May 2, 2023
@torcolvin torcolvin assigned adamcfraser and unassigned torcolvin May 3, 2023
@adamcfraser adamcfraser merged commit 7e3d04f into master May 4, 2023
@adamcfraser adamcfraser deleted the enable-rbac-permissions branch May 4, 2023 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants