Fix RedactableError not satisfying the Redactor interface #6253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
torcolvin
approved these changes
May 17, 2023
| _ error = &RedactableError{} | ||
| _ Redactor = &RedactableError{} | ||
| ) | ||
|
|
||
| // Create a new redactable error. Same signature as fmt.Errorf() for easy drop-in replacement. |
There was a problem hiding this comment.
This code seems fine, although you can't use %w which is always tempting to use around errors, I'd drop a comment. If you wrap this error, I also think the redaction stops working so I worry about this use.
This code is unused though so I wonder if it's worth keeping around?
There was a problem hiding this comment.
- I agree, this type predated
%w- we should figure out what to do about that when we have time. CBG-2997 RedactableErroris used ... ?
bbrks
added a commit
that referenced
this pull request
Oct 6, 2023
1 task
bbrks
added a commit
that referenced
this pull request
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
String()method toRedactableErrorto allow it to satisfyRedactoragain.Integration Tests
GSI=true,xattrs=truehttps://jenkins.sgwdev.com/job/SyncGateway-Integration/1785/