Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

small fix for flake on TestReconnectReplicator in jenkins #6296

Merged
merged 1 commit into from
Jun 9, 2023
Merged

small fix for flake on TestReconnectReplicator in jenkins #6296

merged 1 commit into from
Jun 9, 2023

Conversation

gregns1
Copy link
Contributor

@gregns1 gregns1 commented Jun 9, 2023 •
edited
Loading

CBG-0000

Small changes to a test that went in this week. It flakes in Jenkins on replicator status. This change still asserts the replicator disconnects and reconnects, without asserting diretcly on replicator status, to avoid this happening I make use of the NumConnectAttempts stat we have.

Pre-review checklist

  • Removed debug logging (fmt.Print, log.Print, ...)
  • Logging sensitive data? Make sure it's tagged (e.g. base.UD(docID), base.MD(dbName))
  • Updated relevant information in the API specifications (such as endpoint descriptions, schemas, ...) in docs/api

Integration Tests

@gregns1 gregns1 requested a review from bbrks June 9, 2023 16:43
bbrks
bbrks approved these changes Jun 9, 2023
View reviewed changes
Copy link
Member

@bbrks bbrks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense that this would be more reliable 👍 Thanks!

@gregns1 gregns1 merged commit 76613c4 into master Jun 9, 2023
@gregns1 gregns1 deleted the fix_for_reconnect_flake branch June 9, 2023 16:59
gregns1 added a commit that referenced this pull request Jun 12, 2023
@gregns1
small fix for flake on TestReconnectReplicator in jenkins (#6296)
61023e3
torcolvin pushed a commit that referenced this pull request Jun 12, 2023
@gregns1
small fix for flake on TestReconnectReplicator in jenkins (#6296) (#6299
8bb8ea6 
)
bbrks pushed a commit that referenced this pull request Mar 28, 2024
@gregns1 @bbrks
small fix for flake on TestReconnectReplicator in jenkins (#6296)
7388a44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bbrks bbrks bbrks approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gregns1 @bbrks