Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test fix: TestImportFilterLogging improve assertions #6589

Merged
merged 1 commit into from
Nov 29, 2023

Conversation

bbrks
Copy link
Member

@bbrks bbrks commented Nov 29, 2023

https://mobile.jenkins.couchbase.com/job/sgw-unix-build/30160/

failed because there was also a Rosmar error logged, which caused the numErrors+1 assertion to fail.

2023-11-29T04:14:02.426-08:00 [ERR] c:#067 db:db Javascript: Import <ud>Error</ud> -- db.newImportFilterRunner.func1() at import.go:453
2023-11-29T04:14:02.426-08:00 [ERR] Rosmar: Bucket B#2 error expiring docs: this Rosmar bucket has been closed -- rosmar.logError() at logging.go:56
--- FAIL: TestImportFilterLogging (0.21s)
    import_test.go:583: 
        	Error Trace:	/home/couchbase/jenkins/workspace/sgw-unix-build/3.2.0/enterprise/sync_gateway/rest/importtest/import_test.go:583
        	Error:      	Not equal: 
        	            	expected: 3
        	            	actual  : 4
        	Test:       	TestImportFilterLogging

Tweak test to check for specific error message, and allow >= 1 error

Integration Tests

  • n/a

@torcolvin
Copy link
Collaborator

I am OK to merge this but this test actually was the first sign, albeit not a good one, that there was a problem with the code in couchbaselabs/rosmar#17 . It is a timing issue, which is why it only showed up in jenkins.

@torcolvin torcolvin assigned bbrks and unassigned torcolvin Nov 29, 2023
@bbrks bbrks merged commit 47cbbc8 into master Nov 29, 2023
17 checks passed
@bbrks bbrks deleted the better_assertion_for_TestImportFilterLogging branch November 29, 2023 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants