CBG-3686 add idle kv ops stat #6642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamcfraser
requested changes
Jan 12, 2024
base/heartbeat.go
Outdated
| @@ -280,6 +280,7 @@ func (h *couchbaseHeartBeater) checkStaleHeartbeats(ctx context.Context) error { | |||
| continue | |||
| } | |||
|
|
|||
| SyncGatewayStats.GlobalStats.ResourceUtilizationStats().NumIdleKvOps.Add(1) | |||
There was a problem hiding this comment.
I think we generally want to increment the stat after the operation is performed, not before. Doing it before the error check is fine if that's what you were trying to avoid.
base/sg_cluster_cfg.go
Outdated
| @@ -95,8 +95,8 @@ func (c *CfgSG) Set(cfgKey string, val []byte, cas uint64) (uint64, error) { | |||
| return 0, fmt.Errorf("cfg_sg: key cannot start with a colon") | |||
| } | |||
|
|
|||
| SyncGatewayStats.GlobalStats.ResourceUtilizationStats().NumIdleKvOps.Add(1) | |||
There was a problem hiding this comment.
The PR description said you added this stat for CfgSG.Get, but you've got it on Set here.
Having said that - what Cfg operations are actually being performed by cbgt when the DCP feed is idle? I had thought it was notified about cfg changes via Subscribe(), and didn't do polling.
Remove unused stat for CfgSG. Add docs
adamcfraser
approved these changes
Jan 17, 2024
torcolvin
added a commit
that referenced
this pull request
Jan 30, 2024
adamcfraser
pushed a commit
that referenced
this pull request
Jan 30, 2024
bbrks
pushed a commit
that referenced
this pull request
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setup up two SG nodes in two modes and compared stat on server for idle ops:
CfgSgoperations will only show up if there's multiple SGs.I had uncertainty about what level to put the calls, especially
GetMetadataDocument. In this case, some idle operations are going to get called. I could move this to the bootstrap polling when we callGetDatabaseConfigs. On the other hand, I could move this intoconfig_persistentence.goand cover xattr and non xattr case.For heartbeater, I put the Get cases, but not the updating the node lists, which presumably happens on a rebalance. I think this is most correct.
For
CfgSg, I added for Get operations, since againSetwill happen for ISGR or cbgt DCP rebalance.The concerns I have are as follows:
Pre-review checklist
fmt.Print,log.Print, ...)base.UD(docID),base.MD(dbName))docs/apiIntegration Tests
GSI=true,xattrs=truehttps://jenkins.sgwdev.com/job/SyncGateway-Integration/000/