-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CBG-3869: Fix losing user xattr on import feed for docs with no sync data #6755
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, some tiny test improvements for future debugging.
It'd be cool to have this tested outside RestTester as a unit test on this function. I'm working on a test function to construct a raw body for UnmarshalDocumentSyncDataFromFeed
in CBG-3835
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, some tiny test improvements for future debugging.
It'd be cool to have this tested outside RestTester as a unit test on this function. I'm working on a test function to construct a raw body for UnmarshalDocumentSyncDataFromFeed
in CBG-3835
CBG-3869
rawUserXattr
to the output ofparseXattrStreamData
rawXattr
return to be nil (in event of no sync data) and moved therawUserXattr
to the correct return valuePre-review checklist
fmt.Print
,log.Print
, ...)base.UD(docID)
,base.MD(dbName)
)docs/api
Integration Tests
GSI=true,xattrs=true
https://jenkins.sgwdev.com/job/SyncGateway-Integration/2377/