CBG-3905 scope message about searching for database config #6790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mpt 1/5) This will log once per bucket without the bucket name. This adds the bucket name in the context.
torcolvin
changed the title
bbrks
requested changes
May 1, 2024
Co-authored-by: Ben Brooks <ben.brooks@couchbase.com>
bbrks
approved these changes
May 1, 2024
torcolvin
added a commit
that referenced
this pull request
May 1, 2024
* clarify message about [INF] Config: GetDatabaseConfigs starting (attempt 1/5) This will log once per bucket without the bucket name. This adds the bucket name in the context. * Log first attempt on trace and subsequent attempts on info * Update rest/config_manager.go Co-authored-by: Ben Brooks <ben.brooks@couchbase.com> --------- Co-authored-by: Ben Brooks <ben.brooks@couchbase.com>
3 tasks
bbrks
added a commit
that referenced
this pull request
May 1, 2024
…config (#6790) (#6800) * clarify message about [INF] Config: GetDatabaseConfigs starting (attempt 1/5) This will log once per bucket without the bucket name. This adds the bucket name in the context. * Log first attempt on trace and subsequent attempts on info * Update rest/config_manager.go --------- Co-authored-by: Ben Brooks <ben.brooks@couchbase.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On startup, this will log as follows, which is confusing at best for what it is doing.
I'm not sure if INFO logging is already too aggressive here, this was added in #6720 and will log every 10s.
Change the code to log the bucket name everywhere in this function by context and drop the logging for this message to trace if this is the first attempt, and info on attempt > 1. I think warn is too much for logging attempts 2/5, because on a simultaneous update to the config the bootstrap config could fail, and we will log warning after attempt 5 fails.
I think the best thing a reviewer could do is to run Sync Gateway with and without some buckets and see if the logging verbosity makes sense.