Add new tests for WriteUpdateWithXattrs,WriteTombstoneWithXattrs #6816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
torcolvin
force-pushed
the
CBG-3895-testcase-only
branch
from
e970446 to
cb34caa
Compare
torcolvin
force-pushed
the
CBG-3895-testcase-only
branch
from
30d2917 to
a6e7962
Compare
adamcfraser
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This only includes the test cases that can be run on main branch with changes upcoming in CBG-3895. I'd like to commit these first, and then the reviewer can review the changes to the code that I've made.
There will be more code added because the API will support
xattrsToDeletefor these two functions. I have made no attempt to validate the behavior, it is exactly the behavior of the current code on main. I think behavioral changes could be evaluated when you see the divergence of behavior.The biggest thing out of this review is to determine the style of these tests and if I'm missing test cases to cover.