Fix skipped user-functions tests #6838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The skipped tests in db/functions appear to work fine now. - The functionsapitest failures were due to inadvertently enabling "admin party" when the intent was for the guest user not to have channel access; fixed that in the config. - There was another failure in TestJSFunctionAsGuest due to reversed order of args in assert.Contains.
...instead of its own copy of the identical code.
adamcfraser
approved these changes
May 22, 2024
|
Changes look good. Kicked off integration tests to sanity check CBS behaviour, will merge when that run completes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple of user-functions tests had
t.Skip()applied to them because they weren't working at the time. Some of them appear to work fine now, others needed a small fix.Pre-review checklist
fmt.Print,log.Print, ...)base.UD(docID),base.MD(dbName))docs/apiDependencies (if applicable)
Integration Tests
GSI=true,xattrs=truehttps://jenkins.sgwdev.com/job/SyncGateway-Integration/2444/