CBG-3953: [3.1.9 backport] Avoid timeout on creating indexes asynchronously #6934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* CBG-3941 use infinite waiting for database init manager - create a LeakyClusterOnlyN1QLStore to allow better testing of init manager. - wait for 15 minutes for index creation except via database init manager. - remove unnecessary waiting for index if BUILD INDEX fails with a retryable error, since we already wait later for the index. * wipe out testing changes * Add RetryLoop test * remove more unnecessary test changes * Fix retry condition * Update base/collection_n1ql_common.go Co-authored-by: Adam Fraser <adam.fraser@couchbase.com> * Remove possibly expensive time calculation * Change signature for leaky datastore --------- Co-authored-by: Adam Fraser <adam.fraser@couchbase.com>
torcolvin
reviewed
Jul 3, 2024
base/leaky_datastore.go
Outdated
| @@ -26,7 +27,7 @@ type LeakyDataStore struct { | |||
| var ( | |||
| _ DataStore = &LeakyDataStore{} | |||
| _ WrappingDatastore = &LeakyDataStore{} | |||
| // _ N1QLStore = &LeakyDataStore{} // TODO: Not implemented | |||
| _ N1QLStore = &LeakyDataStore{} | |||
There was a problem hiding this comment.
i think adding n1ql support to leakydatastore is not necessary for this PR (and was speculative on main)
torcolvin
approved these changes
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CBG-3953
Pre-review checklist
fmt.Print,log.Print, ...)base.UD(docID),base.MD(dbName))docs/apiIntegration Tests
GSI=true,xattrs=truehttps://jenkins.sgwdev.com/job/SyncGateway-Integration/2552/