[3.1.9 backport] CBG-4016 Refresh sequence allocator before incr during nextSequenceGreaterThan #6960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eaterThan When nextSequenceGreaterThan requires a sequence larger than what’s already present in the allocator’s batch size, fetch the current _sync:seq before computing the require increment size, to account for variable allocation rates by other allocators.
gregns1
requested changes
Jul 15, 2024
| releasedCount += numReleased | ||
| currentSequence = nextSequence | ||
| } | ||
| currentSequence = nextSequence |
There was a problem hiding this comment.
Nit: have currentSequence = nextSequence twice here
db/sequence_allocator_test.go
Outdated
| require.NoError(t, err, "nextSequenceGreaterThan error: %v", err) | ||
| log.Printf("allocator %d released %d sequences because next < current (%d < %d)", numReleased, allocatorIndex, prevNext, currentSequence) | ||
| // At most clientAllocator should only need to release the current batch | ||
| assert.LessOrEqual(t, numReleased, clientAllocator.sequenceBatchSize) |
There was a problem hiding this comment.
Should include the test fix in #6951
gregns1
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CBG-4016, backports CBG-4015
When nextSequenceGreaterThan requires a sequence larger than what’s already present in the allocator’s batch size, fetch the current _sync:seq before computing the require increment size, to account for variable allocation rates by other allocators.
Integration Tests
GSI=true,xattrs=truehttps://jenkins.sgwdev.com/job/SyncGateway-Integration/2566/