CBG-4117: Add type checking to mandatory audit fields during event validation #7011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… pass it into audit event as raw json
torcolvin
approved these changes
Jul 24, 2024
bbrks
changed the title
bbrks
added a commit
that referenced
this pull request
Jul 26, 2024
… audit fields during event validation (#7011) * misc audit field type changes * More audit field type corrections * Read handlePutDbAuditConfig into bytes before unmarshalling so we can pass it into audit event as raw json * Type check mandatory field values to ensure consistency with the defined event * uint -> uint32 for audit ID
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CBG-4117
Previously #6987
Ensures that the type for the field in the event declaration matches the one actually being passed (when validating during devmode)
Caught a few instances of fields not matching their definitions and potential bugs as a result:
AuditFieldPayloadin some cases was taking either[]byteor a struct, instead ofstring[]bytewill be a base64 encoded string in JSON)handlePutDbAuditConfigwas printing the resulting config, rather than the request payload.stringvs.boolfor a minor difference in output.AuditFieldIDswitched touint32in all placesintanduint64types, but 32bit uints are plenty to represent audit IDsAuditFieldTimestamptime.Time->stringexpandFieldsnow writes aRFC3339formatted timestamp directly, instead of relying on the underlying JSON marshalling oftime.Time. Gives us better control of format.Integration Tests
GSI=true,xattrs=truehttps://jenkins.sgwdev.com/job/SyncGateway-Integration/2614/