Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CBG-3838 fix TestAttachmentDeleteOnExpiry flake #7368

Merged
merged 2 commits into from
Feb 11, 2025
Merged

CBG-3838 fix TestAttachmentDeleteOnExpiry flake #7368

merged 2 commits into from
Feb 11, 2025

Conversation

torcolvin
Copy link
Collaborator

CBG-3838 make sure document gets fully imported before next step occurs.

The rare race condition for this test occurred when a document gets imported by import listener and then the on demand import got cancelled, but before the attachments are deleted. Attachments are deleted

err = db.dataStore.Delete(previousAttachmentID)
but document is updated

@torcolvin torcolvin merged commit 3368f84 into main Feb 11, 2025
38 checks passed
@torcolvin torcolvin deleted the CBG-3838 branch February 11, 2025 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants