Issue #775 - handle sequences deduplicated by server feed #798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| doc.RecentSequences = make([]uint64, 0, 1+len(unusedSequences)) | ||
| } | ||
|
|
||
| if len(doc.RecentSequences) > 20 { |
There was a problem hiding this comment.
Can you refactor 20 into a named constant? (DedupWindowSize?)
…s on the buffered feed as appropriate. Works in standalone testing - still needs unit tests.
| @@ -27,6 +27,7 @@ type syncData struct { | |||
| Flags uint8 `json:"flags,omitempty"` | |||
| Sequence uint64 `json:"sequence"` | |||
| UnusedSequences []uint64 `json:"unused_sequences,omitempty"` | |||
| RecentSequences []uint64 `json:"recent_sequences,omitempty"` | |||
There was a problem hiding this comment.
Can you add docs for this field? I realize it won't "match" the other undocumented fields, but I think the ugliness is worth it from the perspective of someone trying to understand this struct. Actually these docs that were elsewhere in the code look perfect:
The server TAP/DCP feed will deduplicate multiple revisions for the same doc if they occur in the same mutation queue processing window. This results in missing sequences on the change listener. To account for this, we track the recent sequence numbers for the document.
tleyden
force-pushed
the
feature/issue_775
branch
from
7458496 to
314388d
Compare
tleyden
force-pushed
the
feature/issue_775
branch
from
0e5f68d to
a8165f6
Compare
tleyden
added a commit
that referenced
this pull request
Apr 27, 2015
Issue #775 - handle sequences deduplicated by server feed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Write recent sequences to _sync metadata, to handle the case where the TAP or DCP feed deduplicates rapid multiple updates to the same doc.