Soe fix mongodb array deep scan #10
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…within the visited country. previously would match all customers that visited the country and visited the city. now matches only customers that visited the city within the country.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix incorrect MongoDB soeArrayDeepScan: enforce that matched city is within the visited country. previously would match all customers that visited the country and visited the city. now matches only customers that visited the city within the country.
Compare the following two playgrounds:
old way:
https://mongoplayground.net/p/Dlcon5iRMfT
new way:
https://mongoplayground.net/p/D3Ueco07P8z
We want to find customers that have visited Sydney in Australia. The old query would match a customer that has visited cities in Australia (but not Sydney in Australia) and Sydney, Canada. The new query only matches the customers that has visited Sydney, Australia.