Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Icon.Text and TS definition #339

Merged
merged 6 commits into from
Jun 11, 2021
Merged

Add Icon.Text and TS definition #339

merged 6 commits into from
Jun 11, 2021

Conversation

couds
Copy link
Owner

@couds couds commented May 28, 2021

Move Icon.Text as his own component as suggested on Discussion #338

@couds couds requested a review from kennethnym May 28, 2021 07:17
@coveralls
Copy link

coveralls commented May 28, 2021 •
edited
Loading

Coverage Status

Coverage decreased (-0.7%) to 92.447% when pulling 01eded7 on create-icon-text-component into e1416f4 on master.

kennethnym
kennethnym requested changes May 28, 2021
View reviewed changes
Copy link
Collaborator

@kennethnym kennethnym left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Can you also please add some descriptions for the props of Icon? Somehow I missed it when making the documentation.

@couds couds requested a review from kennethnym May 30, 2021 06:36
kennethnym
kennethnym requested changes May 30, 2021
View reviewed changes
Copy link
Collaborator

@kennethnym kennethnym left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one more change. Thanks!

@couds couds requested a review from kennethnym June 6, 2021 08:57
kennethnym
kennethnym approved these changes Jun 6, 2021
View reviewed changes
Copy link
Collaborator

@kennethnym kennethnym left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks again.

@couds couds merged commit 5cb041b into master Jun 11, 2021
@couds couds deleted the create-icon-text-component branch June 11, 2021 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kennethnym kennethnym kennethnym approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@couds @coveralls @kennethnym