Enabling Ruby warnings #242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This means rewrite the logic that parses the attributes. Instead of looking at the large array of methods we just take a look at the methods that our objects will support and we based our conditional flow on that.
rposborne
added a commit
that referenced
this pull request
Mar 12, 2015
|
Thanks for this @franckverrot love killing stuff like this! |
|
0.11.2 released! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These commits are removing some of the warnings that appears when running a dependent gem/app in verbose mode (
ruby -w).Some of those warnings are code-smells, so that's why I'm trying to get rid of them.
Please tell me if you wanna squash those. I didn't as they're basically isolated and independent from one another.
Thanks for this gem!