Add Oauth2 support #114
Closed
Add Oauth2 support #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 13 commits
February 5, 2021 18:54
alex-schneider
force-pushed
the
oauth2
branch
from
858d5be to
dcad170
Compare
johakoch
reviewed
Feb 11, 2021
|
|
||
| pa, passOK := content.Attributes["client_secret"] | ||
| pv, _ := pa.Expr.Value(evalCtx) | ||
| pass := seetie.ValueToString(pv) |
There was a problem hiding this comment.
Ich würde hier nicht von user und pass sprechen; die OAuth2-Nomenklatur ist client id und client secret. Also user -> clientId und pass -> clientSecret?
johakoch
reviewed
Feb 11, 2021
| return "", "", "", fmt.Errorf("Missing OAuth2 'client_id' or 'client_secret' value") | ||
| } | ||
|
|
||
| key := oa.config.TokenEndpoint + "|" + user + "|" + pass |
There was a problem hiding this comment.
Ist der letzte Bestandteil des key (also das client secret) nötig? Die client id ist pro authorization server eindeutig; client id und secret sind unveränderlich.
|
See #130 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.