Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change variable names: req, ctx, bereq, beresp #181

Merged
merged 2 commits into from
Apr 7, 2021

Conversation

malud
Copy link
Collaborator

@malud malud commented Apr 6, 2021

request, context, backend_requests, backend_responses

Closes #180

request, context, backend_requests, backend_responses
@malud malud force-pushed the rename-variables branch from d3cabc4 to 5ed68a0 Compare April 6, 2021 12:51
docs/README.md Outdated

#### `bereq` (modified backend request) variable
`backend_requests.<label>` ist a list of all backend requests, and their variables.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
`backend_requests.<label>` ist a list of all backend requests, and their variables.
`backend_requests.<label>` is a list of all backend requests and their variables.

docs/README.md Outdated

#### `bereq` (modified backend request) variable
`backend_requests.<label>` ist a list of all backend requests, and their variables.
To access a specific request use the related label. Request and Proxy blocks without a label will be
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
To access a specific request use the related label. Request and Proxy blocks without a label will be
To access a specific request use the related label. `request` and `proxy` blocks without a label will be

docs/README.md Outdated

#### `beresp` (original backend response) variable
`backend_responses.<label>` ist a list of all backend responses, and their variables. Same behaviour as for `backend_requests`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
`backend_responses.<label>` ist a list of all backend responses, and their variables. Same behaviour as for `backend_requests`.
`backend_responses.<label>` is a list of all backend responses and their variables. Same behaviour as for `backend_requests`.

docs/README.md Outdated
#### `beresp` (original backend response) variable
`backend_responses.<label>` ist a list of all backend responses, and their variables. Same behaviour as for `backend_requests`.
Use the related label to access a specific response.
Request and Proxy blocks without a label will be available as `default`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Request and Proxy blocks without a label will be available as `default`.
`request` and `proxy` blocks without a label will be available as `default`.

docs/README.md Outdated
@@ -709,13 +713,13 @@ definitions {
### Path Parameter

An endpoint label could be defined as `endpoint "/app/{section}/{project}/view" { ... }`
to access the named path parameter `section` and `project` via `req.path_param.*`.
to access the named path parameter `section` and `project` via `request.path_param.*`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
to access the named path parameter `section` and `project` via `request.path_param.*`.
to access the named path parameter `section` and `project` via `request.path_params.*`.

@alex-schneider alex-schneider merged commit 40b5c92 into master Apr 7, 2021
@alex-schneider alex-schneider deleted the rename-variables branch April 7, 2021 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename short request and response related variable names
3 participants