Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix basic auth #293

Merged
merged 10 commits into from
Aug 20, 2021
Merged

Fix basic auth #293

merged 10 commits into from
Aug 20, 2021

Conversation

alex-schneider
Copy link
Contributor

Currently the Basic Auth does not work if only htpasswd_file is used.

Reviewer checklist
  • Read PR description: a summary about the changes is required
  • Changelog updated
  • Documentation: docs/{Reference, Cli, ...}, Docker and cli help/usage
  • Pulled branch, manually tested
  • Verified requirements are met
  • Reviewed the code
  • Reviewed the related tests

malud
malud requested changes Aug 19, 2021
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
accesscontrol/basic_auth_test.go Outdated Show resolved Hide resolved
@malud malud merged commit 256db62 into master Aug 20, 2021
@malud malud deleted the fix-basic-auth branch August 20, 2021 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malud malud malud approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alex-schneider @malud