Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate couper configuration #296

Merged
merged 46 commits into from
Nov 17, 2021
Merged

Validate couper configuration #296

merged 46 commits into from
Nov 17, 2021

Conversation

alex-schneider
Copy link
Contributor

@alex-schneider alex-schneider commented Aug 20, 2021 •
edited by malud
Loading

Closes #188 #168

Reviewer checklist
  • Read PR description: a summary about the changes is required
  • Changelog updated
  • Documentation: docs/{Reference, Cli, ...}, Docker and cli help/usage
  • Pulled branch, manually tested
  • Verified requirements are met
  • Reviewed the code
  • Reviewed the related tests

@alex-schneider alex-schneider changed the title Validate couper configuration WIP: Validate couper configuration Aug 20, 2021
@alex-schneider alex-schneider linked an issue Sep 2, 2021 that may be closed by this pull request
Missing check for attribute assignments on config load #168
Closed
Alex Schneider added 2 commits September 2, 2021 16:30
@alex-schneider alex-schneider changed the title WIP: Validate couper configuration Validate couper configuration Sep 2, 2021
malud
malud requested changes Sep 15, 2021
View reviewed changes
command/verify.go Outdated Show resolved Hide resolved
command/verify.go Outdated Show resolved Hide resolved
command/verify.go Outdated Show resolved Hide resolved
command/verify.go Outdated Show resolved Hide resolved
config/error_handler.go Outdated Show resolved Hide resolved
main.go Show resolved Hide resolved
Alex Schneider added 18 commits September 29, 2021 16:43
Check for oauth2 in a backend block
3c1b57b
Merge branch 'master' into validate-config
eb6a9ae
Fix tests, add inline interface to jwt
cac7b84
Do not return empty errors
12bd3a1
AccessControlSetter only with right context blocks
a7722cf
Merge branch 'master' into validate-config
b78854a
Merge branch 'master' into validate-config
a3dd262
Merge branch 'master' into validate-config
8c84746
Merge branch 'master' into validate-config
66fc9ae
Merge branch 'master' into validate-config
970cd37
Merge branch 'master' into validate-config
b6471cc
Fix test
fe6debc
Merge branch 'master' into validate-config
58ca13b
Fix merge conflicts
ebb0000
Fix tests
e5ec307
Merge branch 'master' into validate-config
475d614
Merge branch 'master' into validate-config
ca2659a
Merge branch 'master' into validate-config
bc0b766
malud
malud requested changes Nov 16, 2021
View reviewed changes
Copy link
Collaborator

@malud malud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm so far.

main_test.go Outdated Show resolved Hide resolved
main_test.go Outdated Show resolved Hide resolved
@malud malud merged commit e0a7df1 into master Nov 17, 2021
@malud malud deleted the validate-config branch November 17, 2021 11:19
@malud malud mentioned this pull request Nov 23, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malud malud malud approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Check for unknown attributes on config load Missing check for attribute assignments on config load
3 participants
@alex-schneider @malud @johakoch