-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use jwt block for signing #309
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ew jwt package to avoid include cycle
…WTSigningConfigFromJWT() to seperate functions
…as a jwt_signing_profile block
malud
reviewed
Sep 3, 2021
docs/REFERENCE.md
Outdated
| :-------- | :--------------- | :--------------- | :--------------- | :--------------- | :--------------- | | ||
| `signing_key` |string|-|Private key (in PEM format) for `RS*` variants.|-|-| | ||
| `signing_key_file` |string|-|Optional file reference instead of `signing_key` usage.|-|-| | ||
| `signing_ttl` |string|-|The token's time-to-live (creates the `exp` claim).|-|-| |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Type duration
, see line 294
alex-schneider
approved these changes
Sep 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to simplify local JWT handling (create/sign and check), it should be possible to also reference
jwt
blocks from thejwt_sign()
function.To do this, we need
signing_ttl
andsigning_key
/signing_key_file
.So, for JWT signed with an
HS256
keycould be simplified to