Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allowed methods #444

Merged
merged 16 commits into from
Mar 21, 2022
Merged

Allowed methods #444

merged 16 commits into from
Mar 21, 2022

Conversation

johakoch
Copy link
Collaborator

Specify allowed methods using the allowed_methods attribute in api or endpoint blocks.

Reviewer checklist
  • Read PR description: a summary about the changes is required
  • Changelog updated
  • Documentation: docs/{Reference, Cli, ...}, Docker and cli help/usage
  • Pulled branch, manually tested
  • Verified requirements are met
  • Reviewed the code
  • Reviewed the related tests

@johakoch johakoch marked this pull request as ready for review February 23, 2022 17:21
Johannes Koch added 15 commits March 18, 2022 10:53
AllowedMethodsHandler to check allowed methods (between access contro…
c8281aa 
…l and scope)
allowed_methods attribute for api and endpoint blocks
5925f15
wildcard for allowed_methods
1f9a130
CORS preflight: Access-Control-Allow-Methods only set with requested …
795370b 
…method if method is allowed (per allowed_methods or default)
Documentation for allowed_methods
d66ab23
changelog entry
9ee735b
little bit shorter code
377dd8d
moved config file
dc5068c
test cases for blocking request by not allowing any method
74e7686
test cases for invalid strings in allowed_methods
59907f8
upper-case methods only after regexp check
ba6f407
our own added operations (method/endpoint) must be allowed, no need t…
181ba51 
…o check method
removed now unused MustAddRoute() and allowedMethods
afe942b
don't allow TRACE, added test cases for CONNECT
6a2c606
check methods at config load
60ea2f6
malud
malud requested changes Mar 19, 2022
View reviewed changes
config/runtime/server.go Outdated Show resolved Hide resolved
@malud malud merged commit b613096 into master Mar 21, 2022
@malud malud deleted the allowed-methods branch March 21, 2022 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malud malud malud approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johakoch @malud