Fix backend body close #449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johakoch
requested changes
Mar 3, 2022
johakoch
approved these changes
Mar 3, 2022
malud
pushed a commit
that referenced
this pull request
Mar 3, 2022
johakoch
pushed a commit
that referenced
this pull request
Mar 3, 2022
malud
pushed a commit
that referenced
this pull request
Mar 7, 2022
* Fix resource leak for non referenced backend responses * Fixup, except default * Fixup handle default with response block * Add test and changelog * Add additional test cases * Rename backend label * Update path and naming
malud
pushed a commit
that referenced
this pull request
Mar 7, 2022
malud
pushed a commit
that referenced
this pull request
Mar 7, 2022
* Fix resource leak for non referenced backend responses * Fixup, except default * Fixup handle default with response block * Add test and changelog * Add additional test cases * Rename backend label * Update path and naming
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The backend response body is read based on the related endpoint configuration. If a backend response is referenced as variable, we will read its body and transfer the values to our hcl evaluation. On the other side we won't read without reference. That is causing the issue here, we still have to close the body in this situation, giving back its connection.
Reviewer checklist