Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix merge function with tombstone removal #518

Merged
merged 5 commits into from
Jun 8, 2022
Merged

Fix merge function with tombstone removal #518

merged 5 commits into from
Jun 8, 2022

Conversation

malud
Copy link
Collaborator

@malud malud commented Jun 8, 2022 •
edited
Loading

null value properties should not be removed from the resulting object.

Introduced in #141

Reviewer checklist
  • Read PR description: a summary about the changes is required
  • Changelog updated
  • Documentation: docs/{Reference, Cli, ...}, Docker and cli help/usage
  • Pulled branch, manually tested
  • Verified requirements are met
  • Reviewed the code
  • Reviewed the related tests

@malud malud changed the title Add merge function without tombstone removal Fix merge function with tombstone removal Jun 8, 2022
@malud malud marked this pull request as ready for review June 8, 2022 10:12
@afflerbach afflerbach merged commit dbac8a3 into master Jun 8, 2022
@afflerbach afflerbach deleted the null-merge branch June 8, 2022 10:56
afflerbach added a commit that referenced this pull request Jun 8, 2022
@afflerbach
Fixup: removed misleading description (see #518)
81dbde2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afflerbach afflerbach afflerbach approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@malud @afflerbach