-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
channels for sequences #684
Conversation
9f93643
to
111c18c
Compare
I don't think, we need a changelog entry here. |
…relevant for 'api-level error handlers affect endpoint's buffer options' test (checking response body is\!); so split tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just one more func. Even client cancels seems to work as expected.
Hm unstable tests.
Also the openApi test failure I have already seen on this branch. |
I think, both test failures are unrelated to the changes of this PR. If I remember correctly, I saw TestJWKsMaxStale failures somewhere else, too.
Maybe the resource request is sent before the AC has its JWKS information. TestOpenAPIValidator_RelativeServerURL creates a request to the test backend and passes it to an OpenAPI validating backend. No producers involved. However, TestOpenAPIValidator_RelativeServerURL could be improved to actually log the entries before the test is stopped by _, err = backend.RoundTrip(req)
if err != nil {
for _, entry := range hook.AllEntries() {
t.Log(entry.String())
}
helper.Must(err)
} instead of _, err = backend.RoundTrip(req)
if err != nil {
helper.Must(err)
}
if t.Failed() {
for _, entry := range hook.AllEntries() {
t.Log(entry.String())
}
} |
* use channels to pass (error) results to and receive results from proxies/requests * sequence of backend request logs differs, reading log entries is not relevant for 'api-level error handlers affect endpoint's buffer options' test (checking response body is\!); so split tests * remove unused GetPreviousSequence(); no need to export previousSequence * rename function, variables * move adding of independent producers to separate function --------- Co-authored-by: Marcel Ludwig <1841067+malud@users.noreply.github.com> Co-authored-by: Alex Schneider <alex.schneider@avenga.com> Co-authored-by: Marcel Ludwig <marcel.ludwig@milecrew.com> (cherry picked from commit c3c7c59)
use channels to pass (error) results to and receive results from proxies/requests
Reviewer checklist