Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

707 allow super kind errors, match proper error handler #753

Merged
merged 4 commits into from
Apr 12, 2023
Merged

707 allow super kind errors, match proper error handler #753

merged 4 commits into from
Apr 12, 2023

Conversation

johakoch
Copy link
Collaborator

@johakoch johakoch commented Apr 3, 2023

  • I opted against inventing new specific error type and instead allowed for generic types (like "backend") to be registered in handlersPerKind (only "*" is deleted).
  • By sorting the keys in superKindMap in reverse order, "*" now comes last, registering only for the remaining "free" error types.
Reviewer checklist
  • Read PR description: a summary about the changes is required
  • Changelog updated
  • Documentation: docs/{Reference, Cli, ...}, Docker and cli help/usage
  • Pulled branch, manually tested
  • Verified requirements are met
  • Reviewed the code
  • Reviewed the related tests

@johakoch johakoch linked an issue Apr 3, 2023 that may be closed by this pull request
generic backend error cannot be handled by backend error handler #707
Closed
@johakoch johakoch marked this pull request as ready for review April 3, 2023 16:40
Johannes Koch added 4 commits April 6, 2023 12:05
test for a) allowing backend error to be handled by backend error_han…
26c94fb 
…dler and b) generally selecting proper super-kind error_handler
a) allowing backend error to be handled by backend error_handler: onl…
6c2d22a 
…y delete handler for '*' and b) sort super-kinds so that '*' error_handler is only default
changelog entry
956c6fc
as 'regular' access control errors don't have a context, they are not…
3a8b319 
… relevant for the problem
@johakoch johakoch force-pushed the 707-allow-super-kind-errors-match-proper-error_handler branch from bd047e6 to 3a8b319 Compare April 6, 2023 10:06
@alex-schneider alex-schneider merged commit b4fc47a into master Apr 12, 2023
@alex-schneider alex-schneider deleted the 707-allow-super-kind-errors-match-proper-error_handler branch April 12, 2023 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alex-schneider alex-schneider alex-schneider approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

generic backend error cannot be handled by backend error handler
2 participants
@johakoch @alex-schneider