Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

798 dont ignore number only keys #799

Merged
merged 4 commits into from
Feb 2, 2024
Merged

798 dont ignore number only keys #799

merged 4 commits into from
Feb 2, 2024

Conversation

johakoch
Copy link
Collaborator

@johakoch johakoch commented Feb 2, 2024

  • process number-starting keys in MapToValue()
  • process number-starting header field names in HeaderToMapValue()
Reviewer checklist
  • Read PR description: a summary about the changes is required
  • Changelog updated
  • Documentation: docs/{Reference, Cli, ...}, Docker and cli help/usage
  • Pulled branch, manually tested
  • Verified requirements are met
  • Reviewed the code
  • Reviewed the related tests

@johakoch johakoch linked an issue Feb 2, 2024 that may be closed by this pull request
seetie.MapToValue() ignores keys starting with number #798
Closed
@johakoch johakoch marked this pull request as ready for review February 2, 2024 12:48
@malud malud merged commit 9e6a1ce into master Feb 2, 2024
2 checks passed
@malud malud deleted the 798-dont-ignore-number-only-keys branch February 2, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malud malud malud approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

seetie.MapToValue() ignores keys starting with number
2 participants
@johakoch @malud