Add free endpoints #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malud
approved these changes
Jan 19, 2021
Closed
malud
requested changes
Jan 19, 2021
There was a problem hiding this comment.
LGTM so far but does not fulfil the specification requirements from #52 .
The server block should have the same options to reference or override a backend block as the api block does. We should not support inline backends with own labels since this would bring unnecessary complexity to the couper config.
Documentation.
alex-schneider
force-pushed
the
add-free-endpoints
branch
2 times, most recently
from
162a874 to
cae90a6
Compare
malud
force-pushed
the
add-free-endpoints
branch
from
d2ec48c to
a0ce542
Compare
no quoting due to (escaped) json log
malud
approved these changes
Jan 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.