Initial version of MCP server #5

cournape · 2025-10-11T05:05:29Z

This is a slightly cleaned up version of what I demoed no 10th October AI tinkerers day.

Copilot

Pull Request Overview

Initial implementation of an MCP (Model Context Protocol) server for the text2synth project, adding the ability to expose synthesizer control functions as MCP tools.

Adds MCP server functionality with dynamic function generation from Pydantic models
Implements synthesizer state management with MIDI output capabilities
Refactors file loading to support both file paths and file objects

Reviewed Changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
src/text2synth/mcp_server.py	Core MCP server implementation with function factory and synthesizer control
src/text2synth/state.py	Adds file object loading support and fixes linting issue
tests/test_mcp_server.py	Test suite for the function factory functionality
pyproject.toml	Adds MCP dependency and updates test coverage configuration
.python-version	Downgrades Python version from 3.13.5 to 3.12.11

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Copilot · 2025-10-11T05:06:17Z

src/text2synth/mcp_server.py

+    Function factory from a Pydantic model. Created function can be then
+    exposed as MCP tools through FastMCP.
+
+    The created function will have a signature that is kw-only, wich one


Corrected spelling of 'wich' to 'which'.

Suggested change

The created function will have a signature that is kw-only, wich one

The created function will have a signature that is kw-only, which one

Copilot · 2025-10-11T05:06:17Z

src/text2synth/mcp_server.py

+    The created function will have a signature that is kw-only, wich one
+    keyword per field. Critically, the generated function will have a docstring
+    and __signature__ that maps the fields, type and description for the
+    pydantic class. This exposes the right info when exposting


Corrected spelling of 'exposting' to 'exposing'.

Suggested change

pydantic class. This exposes the right info when exposting

pydantic class. This exposes the right info when exposing

Copilot · 2025-10-11T05:06:17Z

src/text2synth/mcp_server.py

+    # Note: None is for explicit -> None, not for no annotation
+    sig = inspect.Signature(params, return_annotation=None)
+
+    # FIXME: missing __annotations__


The FIXME comment indicates incomplete implementation. The function is missing annotations which should be set for proper introspection.

Suggested change

# FIXME: missing __annotations__

# Set __annotations__ for proper introspection

generated_func.__annotations__ = {**model_class.__annotations__, 'return': None}

Copilot · 2025-10-11T05:06:17Z

src/text2synth/mcp_server.py

+    #print("=" * 80)
+    #print(update_synth.__doc__)
+    #print("=" * 80)
+    #print(update_synth.__signature__)
+    #print("=" * 80)


Commented-out debug code should be removed before merging to production.

Suggested change

#print("=" * 80)

#print(update_synth.__doc__)

#print("=" * 80)

#print(update_synth.__signature__)

#print("=" * 80)

Copilot · 2025-10-11T05:06:17Z

src/text2synth/mcp_server.py

+    logger = logging.getLogger(__name__)
+    logging.basicConfig(level=logging.DEBUG)
+
+    logger.debug("YOLO")


Debug log message 'YOLO' should be replaced with a meaningful message or removed.

Suggested change

logger.debug("YOLO")

logger.debug("Starting MCP server")

Copilot

Pull Request Overview

Copilot reviewed 5 out of 6 changed files in this pull request and generated 3 comments.

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Copilot · 2025-10-11T05:23:08Z

src/text2synth/mcp_server.py

+    # Note: None is for explicit -> None, not for no annotation
+    sig = inspect.Signature(params, return_annotation=None)
+
+    # FIXME: missing __annotations__


There's a FIXME comment indicating missing annotations implementation. This should be addressed to ensure proper type introspection for the generated functions.

Suggested change

# FIXME: missing __annotations__

# Set __annotations__ for proper type introspection

annotations = {}

for name, param in sig.parameters.items():

if param.annotation is not inspect.Parameter.empty:

annotations[name] = param.annotation

annotations['return'] = None

generated_func.__annotations__ = annotations

Copilot · 2025-10-11T05:23:08Z

src/text2synth/mcp_server.py

+
+
+def update_synth_state(**kw):
+    print(f"Update args {kw}")


Using print() for debugging instead of the configured logger. Replace with LOGGER.debug(f'Update args {kw}') to maintain consistent logging.

Suggested change

print(f"Update args {kw}")

LOGGER.debug(f"Update args {kw}")

Copilot · 2025-10-11T05:23:08Z

tests/test_mcp_server.py

+            a: int = Field(description="first arg") 
+            b: int = Field(description="second arg") 
+
+        def func_ref(a: Optional[int] = None, b : Optional[int] = None) -> None:


Inconsistent spacing around colon. Should be b: Optional[int] = None to match Python style conventions.

Suggested change

def func_ref(a: Optional[int] = None, b : Optional[int] = None) -> None:

def func_ref(a: Optional[int] = None, b: Optional[int] = None) -> None:

Copilot

Pull Request Overview

Copilot reviewed 5 out of 6 changed files in this pull request and generated 2 comments.

Comments suppressed due to low confidence (1)

src/text2synth/mcp_server.py:1

Inconsistent encoding between from_path (ascii) and original implementation (utf-8). This could cause decoding errors if the file contains non-ASCII characters.

import inspect

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Copilot · 2025-10-11T07:25:12Z

src/text2synth/mcp_server.py

+    ----------
+    model_class : type[BaseModel]
+        The Pydantic model class to generate a function from
+    wrapped_func :


Parameter type annotation is missing for wrapped_func parameter in the docstring. Should specify 'Callable' as the type.

Suggested change

wrapped_func :

wrapped_func : Callable

Copilot · 2025-10-11T07:25:12Z

src/text2synth/mcp_server.py

+    # Note: None is for explicit -> None, not for no annotation
+    sig = inspect.Signature(params, return_annotation=None)
+
+    annotations = {}


Variable 'annotations' is redefined unnecessarily. It was already defined at line 112 and could be reused instead of creating a new dictionary.

Suggested change

annotations = {}

# Reuse the existing 'annotations' dictionary defined earlier

Copilot

Pull Request Overview

Copilot reviewed 5 out of 6 changed files in this pull request and generated 4 comments.

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Copilot · 2025-10-11T07:38:41Z

src/text2synth/state.py

        JU06AState
            Complete synth state with all parameters set
        """
+        with open(path, 'r', encoding='ascii') as fp:


The encoding changed from 'utf-8' to 'ascii' which is more restrictive and could cause decoding errors if the file contains non-ASCII characters. Consider keeping 'utf-8' encoding unless there's a specific requirement for ASCII-only content.

Suggested change

with open(path, 'r', encoding='ascii') as fp:

with open(path, 'r', encoding='utf-8') as fp:

Copilot · 2025-10-11T07:38:42Z

src/text2synth/mcp_server.py

+            constraints.append(f"Possible values: {', '.join(enum_values)}")
+
+        # Check for numeric constraints (ge, le, gt, lt)
+        elif annotation in (int, float) or (get_origin(annotation) in (int, float)):


The condition get_origin(annotation) in (int, float) will always be False because get_origin() returns generic types like typing.Union or None, not basic types like int or float. This branch may not work as expected for generic type annotations.

Copilot · 2025-10-11T07:38:42Z

src/text2synth/mcp_server.py

+                    range_parts[0] = m.ge
+
+            if range_parts:
+                constraints.append(f"Range: {', '.join(str(range_parts[k]) for k in (0, 1))}")


The code assumes both keys 0 and 1 exist in range_parts, but only the keys that were found (ge=0, le=1) are added. This will cause a KeyError if only one constraint is present. Use range_parts.get(k) or check key existence first.

Suggested change

constraints.append(f"Range: {', '.join(str(range_parts[k]) for k in (0, 1))}")

range_strs = []

if 0 in range_parts:

range_strs.append(f"ge={range_parts[0]}")

if 1 in range_parts:

range_strs.append(f"le={range_parts[1]}")

constraints.append(f"Range: {', '.join(range_strs)}")

Copilot · 2025-10-11T07:38:42Z

src/text2synth/mcp_server.py

+
+
+if __name__ == '__main__':
+    logger = logging.getLogger(__name__)


The variable logger is defined but never used. The code uses the global LOGGER constant instead. Either remove this unused variable or use it consistently throughout the module.

Suggested change

logger = logging.getLogger(__name__)

cournape added 5 commits October 9, 2025 20:48

MAINT: add mcp library.

e84e673

FEAT: add a from_file ctor.

82b574f

FEAT: basic MCP server implementation.

fc8bcd6

MAINT: make ruff check pass.

29ccbb3

TST: add test for non int/enum argument.

8e5dd88

cournape requested a review from Copilot October 11, 2025 05:05

Copilot AI reviewed Oct 11, 2025

View reviewed changes

STY: fix cosmetic issues detected by GH pilot.

25002ac

cournape requested a review from Copilot October 11, 2025 05:22

Copilot AI reviewed Oct 11, 2025

View reviewed changes

ENH: add support for annotation in function factory.

6bb1b01

cournape requested a review from Copilot October 11, 2025 07:24

Copilot AI reviewed Oct 11, 2025

View reviewed changes

STY: fix styling issues.

4707259

cournape requested a review from Copilot October 11, 2025 07:37

Copilot AI reviewed Oct 11, 2025

View reviewed changes

STY: remove unused code.

b684d97

cournape merged commit dba69d6 into main Oct 11, 2025
1 check passed

cournape deleted the feat/simple-mcp-server branch October 11, 2025 10:02

	The created function will have a signature that is kw-only, wich one
	The created function will have a signature that is kw-only, which one

	pydantic class. This exposes the right info when exposting
	pydantic class. This exposes the right info when exposing

	# FIXME: missing __annotations__
	# Set __annotations__ for proper introspection
	generated_func.__annotations__ = {**model_class.__annotations__, 'return': None}

-    # FIXME: missing __annotations__
+    # Set __annotations__ for proper type introspection
+    annotations = {}
+    for name, param in sig.parameters.items():
+        if param.annotation is not inspect.Parameter.empty:
+            annotations[name] = param.annotation
+    annotations['return'] = None
+    generated_func.__annotations__ = annotations

	def func_ref(a: Optional[int] = None, b : Optional[int] = None) -> None:
	def func_ref(a: Optional[int] = None, b: Optional[int] = None) -> None:

	annotations = {}
	# Reuse the existing 'annotations' dictionary defined earlier

	with open(path, 'r', encoding='ascii') as fp:
	with open(path, 'r', encoding='utf-8') as fp:

-                constraints.append(f"Range: {', '.join(str(range_parts[k]) for k in (0, 1))}")
+                range_strs = []
+                if 0 in range_parts:
+                    range_strs.append(f"ge={range_parts[0]}")
+                if 1 in range_parts:
+                    range_strs.append(f"le={range_parts[1]}")
+                constraints.append(f"Range: {', '.join(range_strs)}")



		if __name__ == '__main__':
		logger = logging.getLogger(__name__)

Initial version of MCP server #5

Initial version of MCP server #5

Uh oh!

Conversation

cournape commented Oct 11, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Oct 11, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 11, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 11, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 11, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 11, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Copilot AI Oct 11, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 11, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 11, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Copilot AI Oct 11, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 11, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Copilot AI Oct 11, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 11, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 11, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 11, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants