Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible recommendation to fix Scala installation #239

Merged
merged 2 commits into from
Aug 23, 2024

Conversation

bishabosha
Copy link
Contributor

@bishabosha bishabosha commented Aug 22, 2024

Edit: I tested this now

fixes #238

need to set the binary locations
@bishabosha
Copy link
Contributor Author

With the second commit this is working locally - so now by default (i.e. the latest stable) it will look for the prebuilt binary on GitHub, but for any requested explicit version less than 3.5.0-RC1 its going to install the traditional way

@bjornregnell
Copy link

bjornregnell commented Aug 23, 2024

This is great! many thank @bishabosha

Perhaps write in blog-post and install pages "If you get this warning ... do cs install scala:3.5.0 " ? so people still with old installer get to know the workaround before grit wears.

@tgodzik
Copy link
Collaborator

tgodzik commented Aug 23, 2024

I think this should work with the need for 3.5.0 suffix, no?

@tgodzik
Copy link
Collaborator

tgodzik commented Aug 23, 2024

Thanks Jamie!

@tgodzik tgodzik merged commit 9689e9a into coursier:main Aug 23, 2024
1 check passed
@bjornregnell
Copy link

bjornregnell commented Aug 23, 2024

I think this should work with the need for 3.5.0 suffix, no?

Yes I hope when this fix is out suffix should not be needed. But in the meantime and if people already have downloaded the thing and saved it somewhere or if the warning might resurrect somehow and it maybe doesn't hurt to tell about the work-around... But it depends how long it takes for the fix to get to users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scala 3.5 is using the wrong launcher
4 participants