Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Estonian translations #57

Merged
merged 2 commits into from
May 4, 2020
Merged

Estonian translations #57

merged 2 commits into from
May 4, 2020

Conversation

oliverviljamaa
Copy link
Contributor

@oliverviljamaa oliverviljamaa commented May 4, 2020 •
edited
Loading

Context

To be able to launch in Estonia, we need the messaging in Estonian.

Changes

  • all English messages are translated to Estonian
  • the config hook is configured to return the Estonian ID authentication method and Estonian language based on the URL while we are implementing the config endpoint
  • Estonian translations are used when the config has Estonian set as the default language

Screenshots

Considerations

As seen from the screenshot above, date formatting is not yet done, but an issue for it exists: #49.

@oliverviljamaa oliverviljamaa merged commit 360f915 into master May 4, 2020
@oliverviljamaa oliverviljamaa deleted the estonian-translations branch May 4, 2020 17:40
@oliverviljamaa
Copy link
Contributor Author

Closed #48.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tankenstein Tankenstein Tankenstein approved these changes

@StevePole StevePole StevePole approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oliverviljamaa @StevePole @Tankenstein