-
Notifications
You must be signed in to change notification settings - Fork 7
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
chore(npm): do not npmignore angular/dist + unlock npm (#805)
https://coveord.atlassian.net/browse/CDX-1010 <!-- For Coveo Employees only. Fill this section. CDX-1010 --> ## Proposed changes I discussed with a developer from the npm team here npm/npm-packlist#106 and got a good understanding of their philosophy moving forward with the concept of workspaces and their multi-level ignore files. In short, npm will try to acquire an ignorefile at each directory level and concatenate them. The peculiarity (at least IMO), is that if it acquire a npmignore first, this will have no incidence for the acquisition of the other ignorefile. So, we can end up with a mix of `gitignore` and `npmignore`. I discussed this behavior with the npm team, and they are kinda stuck, so its their least worst option here, so we just have to adapt and make it work. This is what this PR is about. ## Testing - Ran `npm publish --dry-run` on every package and checked them out. ## Prerequisites - [x] npm/npm-packlist#108 - [ ] `npm-cli` released with ☝️
- Loading branch information
1 parent
10dd82a
commit c6f7888
Showing
7 changed files
with
5 additions
and
26 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,4 @@ | ||
# Ignores TypeScript files, but keeps definitions. | ||
!*.d.ts | ||
# Do not ignore dist. | ||
!dist |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters