Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add exports with a request body [UA-8951] #859

Merged
merged 5 commits into from
Sep 30, 2024

Conversation

mpayne-coveo
Copy link
Contributor

Adds the exports with body endpoints from the experimental client in the admin UI here- https://github.com/coveo-platform/admin-ui/blob/135ef77c0705b5c1925ae4df511bae2fc8637571/core/api/src/resources/UAExportsResource.ts

These endpoints are stable, publicly available and on Swagger, and documented.

Acceptance Criteria

  • My changes are publicly available, documented, and deployed in production. (i.e. on Swagger)
  • JSDoc annotates each property added in the exported interfaces
  • The proposed changes are covered by unit tests
  • Commits containing breaking changes a properly identified as such
  • README.md is adjusted to reflect the proposed changes (if relevant)
  • My merge commit message will be conventional (See Conventional Commit)

@mpayne-coveo mpayne-coveo marked this pull request as ready for review September 24, 2024 19:09
@mpayne-coveo mpayne-coveo requested review from a team as code owners September 24, 2024 19:09
@mpayne-coveo
Copy link
Contributor Author

@gdostie @fbeaudoincoveo would either of you have some time to re-review today? 🙏

@mpayne-coveo mpayne-coveo requested a review from a team as a code owner September 27, 2024 18:13
@mpayne-coveo mpayne-coveo added this pull request to the merge queue Sep 30, 2024
Merged via the queue into master with commit a099a95 Sep 30, 2024
5 checks passed
@mpayne-coveo mpayne-coveo deleted the feat/UA-8951_add_export_with_body branch September 30, 2024 20:11
Copy link

🎉 This PR is included in version 55.12.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants